Skip to content

v.builder: fix compile asm file, followup of PR #26211#26227

Merged
spytheman merged 2 commits into
vlang:masterfrom
kbkpbot:fix-builder-compile-asm-file
Dec 31, 2025
Merged

v.builder: fix compile asm file, followup of PR #26211#26227
spytheman merged 2 commits into
vlang:masterfrom
kbkpbot:fix-builder-compile-asm-file

Conversation

@kbkpbot

@kbkpbot kbkpbot commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

I would like to apologize for PR #26211, which forgot to set cc_options to a valid value when handling asm file.

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kbkpbot .

Unfortunately I do not see a way to test it easily in isolation 🤔, without writing a separate test setup, and that can get a bit tricky.

I'll think about it more.

@spytheman spytheman merged commit 8d1b900 into vlang:master Dec 31, 2025
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants