Skip to content

ast,checker,cgen,parser: fix comptime $if assign expr#26242

Merged
spytheman merged 3 commits into
vlang:masterfrom
dy-tea:comptime-if
Jan 4, 2026
Merged

ast,checker,cgen,parser: fix comptime $if assign expr#26242
spytheman merged 3 commits into
vlang:masterfrom
dy-tea:comptime-if

Conversation

@dy-tea

@dy-tea dy-tea commented Jan 1, 2026

Copy link
Copy Markdown
Member

Fixes #26061.

Also partially fixes #26053 but there is an additional issue which is hopefully easier to fix with string interpolation in the $else branch.

Comment thread vlib/v/ast/table.v Outdated
Comment thread vlib/v/checker/checker.v Outdated
Comment thread vlib/v/checker/fn.v
@dy-tea

dy-tea commented Jan 2, 2026

Copy link
Copy Markdown
Member Author

Weird that it doesn't compile on sanitized CI now :/

Comment thread vlib/v/ast/table.v Outdated
@spytheman

Copy link
Copy Markdown
Contributor

Weird that it doesn't compile on sanitized CI now :/

Those failures are unrelated and already fixed on master.

@dy-tea dy-tea marked this pull request as draft January 3, 2026 14:04
@dy-tea

dy-tea commented Jan 3, 2026

Copy link
Copy Markdown
Member Author

If the CI passes it should be ready.

@dy-tea dy-tea marked this pull request as ready for review January 3, 2026 14:36

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dy-tea 🙇🏻 .

@spytheman spytheman merged commit b9e9192 into vlang:master Jan 4, 2026
85 checks passed
@dy-tea dy-tea deleted the comptime-if branch January 4, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$if assignment will crash compiler $match assignment will crash compiler

2 participants