ast: get correct generics for generics struct fn with generic param#26251
Merged
Conversation
spytheman
reviewed
Jan 3, 2026
| converted_args << converted_type_str | ||
| changed = true | ||
| if converted_type.has_flag(.generic) { | ||
| has_generic = true |
Contributor
There was a problem hiding this comment.
if you have a continue here, you can save on the else {} branches below
Contributor
There was a problem hiding this comment.
another alternative is to invert the conditions, and do early if inverted_cond { converted_args << arg continue }, which can save on the depth of the nesting inside the loop
Contributor
|
The CI failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26191.