time: fix overflow in time.sys_mono_now() on windows#26273
Merged
spytheman merged 1 commit intoJan 6, 2026
Merged
Conversation
Contributor
Author
|
Drawbacks: with this approach, a potential overflow could happen, for a stopwatch running for more than 5.8 years: however I think it is an acceptable compromise (the same can happen on macos, that uses a conversion by multiplying/dividing too), and stopwatches are used for measuring a lot shorter durations normally. |
Contributor
Author
|
(the CI failures are not related) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked with running this script on a windows laptop, which failed on master:
On this PR, it produced:
which is consistent with the output on a macos and linux machines.
Fixes: 26265
TLDR: avoid overflow produced by multiplying by 1000000000, just to delete after that by 10000000 . In essence, that is now replaced by multiplying by 100 (for the windows machines we tested on).