gg: optimise the draw_rounded_rect_filled function#26390
Merged
spytheman merged 5 commits intoJan 19, 2026
Conversation
optimisation of draw_rounded_rect_filled by using only 3 shapes
Contributor
Author
|
To check if this work as well as before, a new function has been added in #26389, that way we can compare if it doesn't break anything |
spytheman
reviewed
Jan 19, 2026
spytheman
approved these changes
Jan 19, 2026
spytheman
left a comment
Contributor
There was a problem hiding this comment.
Thank you @Linklancien 🙇🏻 .
I could only test on macos, the result is that the before/after renders look the same to me 🥳, even though the code is less, and generates a smaller number of vertices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to optimise the
draw_rounded_rect_filledfunction by changing how it works:Now instead of drawing four corner and 3 rectangle, it draw the top part, the middle part using a rectangle and the bottom part
The top and bottom part are drawn as follow:
For each angle, you place a new point on each side, right and left using the
sgl.begin_triangle_strip()primitive