new generic stage: more fixes#26391
Merged
Merged
Conversation
spytheman
reviewed
Jan 19, 2026
| str_fn_name = 'builtin__${str_fn_name}' | ||
| } | ||
| if sym.has_method_with_generic_parent('str') { | ||
| if sym.has_method_with_generic_parent('str') && !g.pref.new_generic_solver { |
Contributor
There was a problem hiding this comment.
Suggested change
| if sym.has_method_with_generic_parent('str') && !g.pref.new_generic_solver { | |
| if !g.pref.new_generic_solver && sym.has_method_with_generic_parent('str') { |
Member
Author
There was a problem hiding this comment.
I have put it like that to avoid checking for the new solver even if the condition is not valid, as the new solver is not the default path for now. But if you find this clearer, I can change it
Contributor
There was a problem hiding this comment.
Checking a boolean is faster than doing a fn call, and && does not evaluate its right operand, if the first is false -> it is a good habbit to put the cheap operation on the left side, even if it may not matter much in this case...
Member
Author
There was a problem hiding this comment.
Oh true I did not consider the cost of the fn call. Thank you
spytheman
reviewed
Jan 19, 2026
spytheman
reviewed
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes more tests from
v -new-generic-solver test vlib/v/tests/generics/, status :53 failed, 208 passed, 261 totalcompared to69 failed, 192 passed, 261 totalfor the previous PR