Skip to content

GNUmakefile: Include Macport legacy headers in include path#26614

Merged
spytheman merged 1 commit into
vlang:masterfrom
programmingkidx:legacy-include-path
Feb 16, 2026
Merged

GNUmakefile: Include Macport legacy headers in include path#26614
spytheman merged 1 commit into
vlang:masterfrom
programmingkidx:legacy-include-path

Conversation

@programmingkidx

Copy link
Copy Markdown
Contributor

The Macports header files include code that adds newer constants and functions to older versions of Mac OS X. A lot of the code in these header files are needed to build V on Mac OS 10.4. This patch adds the path of the Macport legacy headers to the CFLAGS variable in the GNUmakefile.

@spytheman spytheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @programmingkidx 🙇🏻 .

@spytheman

Copy link
Copy Markdown
Contributor

What do you think of moving line 113:

$(eval override LDFLAGS+=-L$(realpath $(LEGACYLIBS))/lib -lMacportsLegacySupport)

to the place where this PR appends to CFLAGS as well?

@spytheman spytheman merged commit 95f0fa9 into vlang:master Feb 16, 2026
56 checks passed
@programmingkidx

Copy link
Copy Markdown
Contributor Author

That does sound like a good idea.
Thank you.

cestef pushed a commit to cestef/v that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants