Fix Windows pkgconfig resolution and MSVC flag translation#26631
Merged
medvednikov merged 1 commit intoFeb 20, 2026
Conversation
Contributor
Author
|
Fixes #26628 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae486f19f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ae486f1 to
2c1b41c
Compare
2c1b41c to
9c851ba
Compare
cestef
pushed a commit
to cestef/v
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
V’s internal pkgconfig didn’t set pcfiledir, so ${pcfiledir} expanded to empty and vcpkg paths collapsed to S:\include/S:\lib. This broke MSVC builds (missing ft2build.h) and leaked -L/-l tokens into MSVC. The fix aligns internal pkgconfig behavior with standard pkg-config and makes MSVC robust to gcc-style flag output.
Testing