Fix anonymous function name collisions across files#26642
Merged
Merged
Conversation
Contributor
Author
|
Fixes issue #26641 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7efbef1d33
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
quaesitor-scientiam
force-pushed
the
fix/anon-fn-name
branch
from
7efbef1 to
836e7ff
Compare
Member
|
Will need a test. |
Contributor
Author
Working on it. The test runs under -prod run via the existing modules/ test harness in compiler_errors_test.v. |
Adds a multi-file module test that verifies two anonymous functions with identical signatures in different source files are compiled and linked correctly after the fix in get_anon_fn_name() (PR vlang#26642). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cestef
pushed a commit
to cestef/v
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix anonymous function name collisions across files by including pos.file_idx in the generated name. This prevents duplicate C symbols when two files emit the same anon-fn signature + position.
Before/After (generated C)
Before (master, no file_idx):
insert from master build: anon_fn_7b5497f4437681ea_mut_gui__window_1728
After (this PR, with file_idx):
anon_fn_7b5497f4437681ea_156_mut_gui__window_1728
Tests
\Users\john3.vmodules\gui\examples\showcase.v"