closure: add sparc64 support#26731
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0acd84d57d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ]! | ||
| } $else $if sparc64 { | ||
| [ | ||
| u8(0x91) 0xb0, 0x22, 0x1f, // movdtox %f62, %o0 |
There was a problem hiding this comment.
Add the missing comma in sparc64 get-data bytecode
The new closure_get_data_bytes branch has a malformed array element list: u8(0x91) 0xb0 is missing a comma between bytes, so the thunk byte table is not valid V syntax. This causes compilation to fail when the sparc64 branch is parsed/selected (e.g. building on sparc64), blocking the architecture support this commit is trying to add.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Incorrect. V does not require commas between data elements in an array.
It would be good for the array to be consistent, but is not required.
There was a problem hiding this comment.
Good catch, fixed.
|
At least one error related to this change: |
|
One other thing that just hit me... in the other, related PR, we saw that Just as there's no need for I don't know if it is worth changing that now, just brought it up now that I thought of it. |
I have an idea about what might have confused you — one is the name of a For me, @JalonSolov - Did I confuse you even more? :) Maybe someone else has their own opinion? |
|
As long as that is the "common" name, it is fine. As I said, I don't do sparc. :-) |
The entire foundation for
sparc64is already inmaster.Now we need to enable closure support.
Already verified the patch manually on
sparc64, everything is ok: