Skip to content

Skip run command request when disconnected#11558

Merged
MaggieShan merged 1 commit into
masterfrom
maggs/skip-remote-run-command-on-disconnection
May 22, 2026
Merged

Skip run command request when disconnected#11558
MaggieShan merged 1 commit into
masterfrom
maggs/skip-remote-run-command-on-disconnection

Conversation

@MaggieShan
Copy link
Copy Markdown
Contributor

Description

  • Context: https://warpdev.slack.com/archives/C0AMRA82ZKL/p1779143889865059
  • We're getting a lot of client error related to the run command request failing when the session is disconnected - this pr ensures that we're not sending any run command requests unless the remote server client is actually connected (we reuse the disconnected flag)

Testing

Tested manually that the request is not sent + verified the tests pass

  • I have manually tested my changes locally with ./script/run

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label May 22, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 22, 2026

@MaggieShan

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds a non-blocking disconnected-state check to the remote-server-backed command executor so it skips remote RunCommand requests after the client has observed a disconnect. It also exposes the client disconnected flag and adds focused tests for the flag state.

Concerns

No blocking correctness, security, or spec-alignment concerns found. The provided spec context says no approved or repository spec context was found for this PR.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@MaggieShan MaggieShan merged commit 61e0fd3 into master May 22, 2026
32 checks passed
@MaggieShan MaggieShan deleted the maggs/skip-remote-run-command-on-disconnection branch May 22, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants