Skip to content

innerText setter should not result in empty text nodes#3492

Merged
annevk merged 1 commit intomasterfrom
innertext-empty-text-nodes
Mar 14, 2017
Merged

innerText setter should not result in empty text nodes#3492
annevk merged 1 commit intomasterfrom
innertext-empty-text-nodes

Conversation

@zcorpan
Copy link
Copy Markdown
Member

@zcorpan zcorpan commented Aug 18, 2016

This was referenced Aug 18, 2016
Open
Merged
@ayg ayg closed this Aug 28, 2016
@ayg ayg deleted the innertext-empty-text-nodes branch August 28, 2016 13:58
@zcorpan zcorpan restored the innertext-empty-text-nodes branch August 28, 2016 20:10
@zcorpan zcorpan reopened this Aug 28, 2016
@ayg ayg closed this Oct 26, 2016
@ayg ayg deleted the innertext-empty-text-nodes branch October 26, 2016 17:38
@ayg ayg restored the innertext-empty-text-nodes branch October 26, 2016 18:04
@ayg ayg reopened this Oct 26, 2016
@zcorpan
Copy link
Copy Markdown
Member Author

zcorpan commented Jan 17, 2017

@cdumez r?

@annevk
Copy link
Copy Markdown
Member

annevk commented Mar 14, 2017

Although, maybe rebase and let me have another look?

@zcorpan zcorpan force-pushed the innertext-empty-text-nodes branch from c71a3a1 to 7cfa65b Compare March 14, 2017 13:18
@ghost
Copy link
Copy Markdown

ghost commented Mar 14, 2017

These tests are now available on w3c-test.org

@ghost
Copy link
Copy Markdown

ghost commented Mar 14, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 0dd98b13bc6e711685bf5e7ffd175a1676dec07b
Using browser at version BuildID 20170313110417; SourceStamp f9362554866b327700c7f9b18050d7b7eb3d2b23
Starting 10 test iterations
All results were stable

All results

1 test ran
/innerText/setter.html
Subtest Results Messages
OK
Simplest possible test PASS
Newlines convert to <br> in non-white-space:pre elements PASS
Newlines convert to <br> in <pre> element PASS
Newlines convert to <br> in white-space:pre element PASS
CRs convert to <br> in non-white-space:pre elements PASS
CRs convert to <br> in <pre> element PASS
Newline/CR pair converts to <br> in non-white-space:pre element PASS
Newline/newline pair converts to two <br>s in non-white-space:pre element PASS
CR/CR pair converts to two <br>s in non-white-space:pre element PASS
CRs convert to <br> in white-space:pre element PASS
< preserved PASS
> preserved PASS
& preserved PASS
" preserved PASS
' preserved PASS
innerText not supported on SVG elements PASS
innerText not supported on MathML elements PASS
Null characters preserved PASS
Tabs preserved PASS
Leading whitespace preserved PASS
Trailing whitespace preserved PASS
Whitespace not compressed PASS
Existing text deleted PASS
Existing <br> deleted PASS
Assigning the empty string PASS
Assigning null PASS
Assigning undefined PASS
Start with CR PASS
Start with LF PASS
Start with CRLF PASS
End with CR PASS
End with LF PASS
End with CRLF PASS
innerText on <area> element PASS
innerText on <base> element PASS
innerText on <basefont> element PASS
innerText on <bgsound> element PASS
innerText on <br> element PASS
innerText on <col> element PASS
innerText on <embed> element PASS
innerText on <frame> element PASS
innerText on <hr> element PASS
innerText on <image> element PASS
innerText on <img> element PASS
innerText on <input> element PASS
innerText on <keygen> element PASS
innerText on <link> element PASS
innerText on <menuitem> element PASS
innerText on <meta> element PASS
innerText on <param> element PASS
innerText on <source> element PASS
innerText on <track> element PASS
innerText on <wbr> element PASS
innerText on <colgroup> element PASS
innerText on <frameset> element PASS
innerText on <head> element PASS
innerText on <html> element PASS
innerText on <table> element PASS
innerText on <tbody> element PASS
innerText on <tfoot> element PASS
innerText on <thead> element PASS
innerText on <tr> element PASS

@ghost
Copy link
Copy Markdown

ghost commented Mar 14, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 0dd98b13bc6e711685bf5e7ffd175a1676dec07b
Using browser at version 58.0.3029.14 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/innerText/setter.html
Subtest Results Messages
OK
Simplest possible test PASS
Newlines convert to <br> in non-white-space:pre elements PASS
Newlines convert to <br> in <pre> element PASS
Newlines convert to <br> in white-space:pre element PASS
CRs convert to <br> in non-white-space:pre elements PASS
CRs convert to <br> in <pre> element PASS
Newline/CR pair converts to <br> in non-white-space:pre element PASS
Newline/newline pair converts to two <br>s in non-white-space:pre element FAIL assert_not_equals: Should not have empty text nodes got disallowed value ""
CR/CR pair converts to two <br>s in non-white-space:pre element FAIL assert_not_equals: Should not have empty text nodes got disallowed value ""
CRs convert to <br> in white-space:pre element PASS
< preserved PASS
> preserved PASS
& preserved PASS
" preserved PASS
' preserved PASS
innerText not supported on SVG elements PASS
innerText not supported on MathML elements PASS
Null characters preserved PASS
Tabs preserved PASS
Leading whitespace preserved PASS
Trailing whitespace preserved PASS
Whitespace not compressed PASS
Existing text deleted FAIL assert_not_equals: Child should be a *new* text node got disallowed value Text node "abc"
Existing <br> deleted PASS
Assigning the empty string PASS
Assigning null PASS
Assigning undefined PASS
Start with CR FAIL assert_not_equals: Should not have empty text nodes got disallowed value ""
Start with LF FAIL assert_not_equals: Should not have empty text nodes got disallowed value ""
Start with CRLF FAIL assert_not_equals: Should not have empty text nodes got disallowed value ""
End with CR PASS
End with LF PASS
End with CRLF PASS
innerText on <area> element PASS
innerText on <base> element PASS
innerText on <basefont> element PASS
innerText on <bgsound> element PASS
innerText on <br> element PASS
innerText on <col> element PASS
innerText on <embed> element PASS
innerText on <frame> element PASS
innerText on <hr> element PASS
innerText on <image> element PASS
innerText on <img> element PASS
innerText on <input> element PASS
innerText on <keygen> element PASS
innerText on <link> element PASS
innerText on <menuitem> element PASS
innerText on <meta> element PASS
innerText on <param> element PASS
innerText on <source> element PASS
innerText on <track> element PASS
innerText on <wbr> element PASS
innerText on <colgroup> element PASS
innerText on <frameset> element PASS
innerText on <head> element PASS
innerText on <html> element PASS
innerText on <table> element PASS
innerText on <tbody> element PASS
innerText on <tfoot> element PASS
innerText on <thead> element PASS
innerText on <tr> element PASS

@annevk annevk merged commit f5f8d4f into master Mar 14, 2017
@annevk
Copy link
Copy Markdown
Member

annevk commented Mar 14, 2017

It seems you should maybe file an issue against Chrome, but I suppose you'll track that as part of the HTML issue.

@annevk annevk deleted the innertext-empty-text-nodes branch March 14, 2017 13:30
@zcorpan
Copy link
Copy Markdown
Member Author

zcorpan commented Mar 14, 2017

Commented in https://bugs.chromium.org/p/chromium/issues/detail?id=573309
Filed a new issue for WebKit https://bugs.webkit.org/show_bug.cgi?id=169600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annevk annevk annevk approved these changes

Assignees

No one assigned

Labels

innerText

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zcorpan @annevk @sideshowbarker @ayg @wpt-pr-bot