fix: Add Cmd Default/Input support to cleanup

[tkalus]

Bring post action step into consistency with main for changes introduced in #154.

Without this change, sshAgentCmd is undefined when passed to execFileSync() during cleanup and post is never successful.

Post job cleanup consistently showing:

Stopping SSH agent
The "file" argument must be of type string. Received undefined
Error stopping the SSH agent, proceeding anyway

Also add entries to the CHANGELOG, detailing v0.8.0 and v0.9.0 releases.

Fixes: #208
Fixes: #211

[mpdude]

Makes sense!

Could you please update dist/cleanup.js as well by running npm run build?

[tkalus]

Makes sense!

Could you please update dist/cleanup.js as well by running npm run build?

Thanks for the gentle reminder @mpdude.

Updated via docker using:

$ docker run \
  --interactive \
  --rm \
  --tty \
  --volume ${PWD}:/var/task \
  --workdir /var/task \
  node:16-buster \
  sh -c 'yarn install && npm run build'

Please advise if the update looks incorrect or if you'd like me to use a different version of node or run a modified command.

[tkalus]

@mpdude Is there anything else blocking this?

[sdt]

I'd love to see this PR released. I've got self-hosted runners with tons of ssh-agent processes hanging around.

This fixes it nicely.

[thazhemadam]

Gentle bump on this PR being merged. This would really help with the cleanup of the ssh-agent processes running in the context of non-containerised environments!

[tkalus]

@mpdude, I've rebased my branch from upstream and re-run/updated the dist/ folder.

$ docker run \
    --interactive \
    --rm \
    --tty \
    --volume ${PWD}:/var/task \
    --workdir /var/task \
    node:20-buster \
    sh -c 'npm install -g npm@10.5.0 && yarn install && NODE_OPTIONS=--openssl-legacy-provider npm run build'

Like others above, I'd love to get this into a release.

[sambanks]

Also would love to see this one in for our self hosted runners.

[edelanghe-ledger]

Hi guys, I would love to see this one merged also 🙏 🙏

[bvnp43]

pls merge this pr @mpdude

[jeromecoupe]

Have this warning in Post Loads private SSH key as well on Github hosted runners. If this PR fixes it, would love to see it merged

Stopping SSH agent
The "file" argument must be of type string. Received undefined
Error stopping the SSH agent, proceeding anyway

[bobanj]

y u no merge dis? 😄

[bpedman]

🙏 please merge this PR

[mark-pictor-csec]

@mpdude It'd be nice to see this merged. Anything the community can do to help?

[sanderpick]

does anyone have a stable fork with this fix?

[hcrespozemoga]

@mpdude Hi, I hope you're doing well and I really hope this doesn't bother you, but are there any plans to merge this fix?

[serdardalgic]

Hi everyone! What's missing for this PR to be merged? Is there anything to help?
Because of this bug, a lot of ssh-agent processes are piling up on my stand-alone GHA runner. I'd be happy to help if there is anything I can do.

[janopae]

Thanks for the contribution :) We looked through your PR and just merged a refactored version with #235.