Conversation
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
mls-reset
branch
2 times, most recently
from
23a9405 to
54652e4
Compare
stefanwire
reviewed
May 12, 2025
Contributor
Author
There was a problem hiding this comment.
Ah, thanks for catching this. I wanted to refactor this slightly to avoid invoking the API handler in this case, but I'll move it to a follow-up PR.
Contributor
There was a problem hiding this comment.
Wouldn't this break older API versions?
Contributor
Author
There was a problem hiding this comment.
No, because the API is unchanged. Just the name of the type has changed.
stefanwire
approved these changes
May 12, 2025
We will add it back in a follow-up PR
pcapriotti
added a commit
that referenced
this pull request
May 13, 2025
This reverts commit df5a75f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new endpoint
/mls/reset-conversationwhich can be used to restore an MLS group that ended up in an invalid state for any reason. After resetting, the conversation has the same users, but the corresponding MLS group gets a new group ID and resets to epoch 0 with no clients.https://wearezeta.atlassian.net/browse/WPB-17337
Checklist
changelog.d