WPB-16887 Allow Team Admin to Change a Channel Name#4584
Merged
battermann merged 2 commits intodevelopfrom Jun 11, 2025
Merged
Conversation
zebot
added
the
ok-to-test
battermann
force-pushed
the
WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in
branch
from
9f02a25 to
ba9d7f0
Compare
battermann
force-pushed
the
WPB-16887-allow-team-admin-to-change-a-channels-name
branch
from
6ea46bb to
52b784e
Compare
battermann
force-pushed
the
WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in
branch
from
ba9d7f0 to
b6a9003
Compare
battermann
force-pushed
the
WPB-16887-allow-team-admin-to-change-a-channels-name
branch
from
52b784e to
bf1427a
Compare
battermann
force-pushed
the
WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in
branch
from
b6a9003 to
046ea1a
Compare
battermann
force-pushed
the
WPB-16887-allow-team-admin-to-change-a-channels-name
branch
from
bf1427a to
763a215
Compare
Base automatically changed from
WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in
to
develop
June 11, 2025 09:26
battermann
force-pushed
the
WPB-16887-allow-team-admin-to-change-a-channels-name
branch
from
763a215 to
536e41f
Compare
battermann
force-pushed
the
WPB-16887-allow-team-admin-to-change-a-channels-name
branch
from
536e41f to
d53c8fb
Compare
supersven
approved these changes
Jun 11, 2025
Contributor
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
LGTM 👍
I really like your style of always providing a counter example in test assertions 👍
battermann
deleted the
WPB-16887-allow-team-admin-to-change-a-channels-name
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d