WPB-16886 Get channel data (team admin)#4635
Merged
battermann merged 10 commits intodevelopfrom Jul 10, 2025
Merged
Conversation
battermann
force-pushed
the
WPB-16886-allow-team-admin-to-get-channel-data
branch
from
19dd8e3 to
f5bb41f
Compare
zebot
added
the
ok-to-test
battermann
changed the base branch from
develop
to
WPB-16886-allow-team-admin-to-get-channel-data-preparation
battermann
force-pushed
the
WPB-16886-allow-team-admin-to-get-channel-data-preparation
branch
from
c58b2f5 to
634ab0c
Compare
battermann
force-pushed
the
WPB-16886-allow-team-admin-to-get-channel-data
branch
2 times, most recently
from
3dceea8 to
8822d30
Compare
battermann
force-pushed
the
WPB-16886-allow-team-admin-to-get-channel-data
branch
from
3a1f26d to
4b7cf4f
Compare
battermann
force-pushed
the
WPB-16886-allow-team-admin-to-get-channel-data-preparation
branch
from
eafd28a to
7ab9923
Compare
Base automatically changed from
WPB-16886-allow-team-admin-to-get-channel-data-preparation
to
develop
July 4, 2025 09:58
battermann
force-pushed
the
WPB-16886-allow-team-admin-to-get-channel-data
branch
from
4b7cf4f to
f29a4e1
Compare
akshaymankar
requested changes
Jul 8, 2025
libs/wire-api/src/Wire/API/Routes/Public/Galley/Conversation.hs
Outdated
Show resolved
Hide resolved
libs/wire-api/src/Wire/API/Routes/Public/Galley/Conversation.hs
Outdated
Show resolved
Hide resolved
Comment on lines
169
to
174
| mChannel <- getChannel lusr cnv | ||
| case mChannel of | ||
| Just channel -> pure channel | ||
| Nothing -> | ||
| Mapping.conversationView (qualifyAs lusr ()) (Just lusr) | ||
| <$> getConversationAndCheckMembership (tUntagged lusr) (qualifyAs lusr cnv) |
Member
There was a problem hiding this comment.
Why do we get the conv data twice here in case it is not a channel? Perhaps we can change the getConversationAndCheckMembership to allow an admin to succeed the membership check?
Co-authored-by: Akshay Mankar <[email protected]>
Co-authored-by: Akshay Mankar <[email protected]>
akshaymankar
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d