UserSubsystem: Deduplicate user search results on exact handle match#4656
UserSubsystem: Deduplicate user search results on exact handle match#4656akshaymankar merged 1 commit intodevelopfrom
Conversation
battermann
left a comment
There was a problem hiding this comment.
The fix makes sense, and the test too. What I cannot assess is if the mock interpreter for the user index behaves the same as the real user index. I trust your expertise here.
Personally, I would have reproduced the issue with an integration test and then fix it. But the unit test has a much better resource footprint of course, that is nice.
I don't think it would behave exactly like elasticsearch, but I tried to encode the important parts of our query to ES. The way ES actually orders things is way more complicated and probably not worth replicating because from Wire's perspective the order of results doesn't matter so much. |
https://wearezeta.atlassian.net/browse/WPB-17867
Checklist
changelog.d