Refactor the nginx upstream creation for Joe's PR#4679
Merged
supersven merged 15 commits intoreplace-nginz-disco-by-native-upstream-resolution-WPB-15302from Jul 24, 2025
Conversation
supersven
added
the
ok-to-test
supersven
changed the title
supersven
merged commit 4352f49
into
replace-nginz-disco-by-native-upstream-resolution-WPB-15302
7 checks passed
supersven
deleted the
replace-nginz-disco-by-native-upstream-resolution-WPB-15302_SVEN
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My branch to try refactorings on the base branch (instead of messing with it directly.)
Besides minor cleanups, I'm now using an Attoparsec
Parserto identify and dropupsteam <name> { <code> }blocks (blocks can be nested, thus a simple regex won't help) and Interpolate Template Haskell templates to generate new upstream blocks.Checklist
Add a new entry in an appropriate subdirectory ofchangelog.d