Move account creation to UserStore#4695
Conversation
libs/wire-subsystems/test/unit/Wire/MockInterpreters/UserStore.hs
Outdated
Show resolved
Hide resolved
|
@akshaymankar and I looked at the question of why the invariant on the identity field (mentioned here) doesn't actually seem to be preserved. The issue is that a user is always created in a non-activated state, then, if the email activation code was provided in the request, it is activated afterwards. The user record always has email_unvalidated set to null, and email identity set to the actual email, regardless of the activation state, and the returned user object reflects that. This is close to ok for user created with an activation code, but definitely wrong for non-activated users, since it does not match what the user looks like when queried separately. The plan is to leave this PR as is, since it is a pure refactoring that doesn't change the current behaviour. In a separate PR, we plan to change the API as follows:
|
https://wearezeta.atlassian.net/browse/WPB-18186
Checklist
changelog.d