Skip to content

fix(nginz): also include namespace in upstream name when upstream_namespace is set#4701

Merged
lwille merged 1 commit intodevelopfrom
WPB-19292
Aug 4, 2025
Merged

fix(nginz): also include namespace in upstream name when upstream_namespace is set#4701
lwille merged 1 commit intodevelopfrom
WPB-19292

Conversation

@lwille
Copy link
Contributor

@lwille lwille commented Aug 4, 2025

If upstream_name is set, we're including it in the proxy_pass directive. However, the actual upstreams never included the namespace name.
This PR adds the namespace to the upstream name in the upstream declaration, so that proxy_pass is not running into a 504 error for such services.

related to WPB-19292

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@lwille lwille requested review from a team as code owners August 4, 2025 16:34
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 4, 2025
@lwille lwille merged commit 5fe153f into develop Aug 4, 2025
8 checks passed
@lwille lwille deleted the WPB-19292 branch August 4, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants