WPB-19693 fix role filter in team search endpoint

[battermann]

https://wearezeta.atlassian.net/browse/WPB-19693

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

[eyeinsky]

This looks good to me! The tests are also easy to read for someone new to the codebase. :)

Just two questions to improve my understanding:

• was the bug in the instance FromHttpApiData Role than needed an explicit mapping?
• is the search index update related to the bug fix? I guess if it is then the index is updated before the search happens, but I can't find this relation in the code, I guess it was already present before the changes in this PR?

[eyeinsky]

Also, I guess the https://wearezeta.atlassian.net/browse/WPB-11124 ticket can be closed now.

[battermann]

Also, I guess the https://wearezeta.atlassian.net/browse/WPB-11124 ticket can be closed now.

yes when this is merged

[battermann]

This looks good to me! The tests are also easy to read for someone new to the codebase. :)

Just two questions to improve my understanding:

• was the bug in the instance FromHttpApiData Role than needed an explicit mapping?
• is the search index update related to the bug fix? I guess if it is then the index is updated before the search happens, but I can't find this relation in the code, I guess it was already present before the changes in this PR?

Actually, it is/was all:

• the parser didn't work
• the field in the index was neither set nor updated
• the role filter was ignored when doing queries.

[akshaymankar]

I think force updating on normal updates is not good when we can compute the write time of the role of the user.

[akshaymankar]

Looks good