WPB-20206 create a new feature flag asset audit log#4779
Merged
battermann merged 2 commits intodevelopfrom Sep 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new feature flag AssetAuditLog to the Wire server codebase. The feature flag is designed to be global and immutable, with no configuration payload and always locked status.
- Implements
AssetAuditLogConfigfeature flag infrastructure across the API and type system - Adds configuration support in Helm charts and deployment files
- Includes comprehensive test coverage for the new feature flag
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libs/wire-api/src/Wire/API/Team/Feature.hs | Defines the AssetAuditLogConfig type and implements required feature interfaces |
| services/galley/src/Galley/API/Teams/Features/Get.hs | Adds GetFeatureConfig instance for AssetAuditLogConfig |
| services/galley/src/Galley/API/Public/Feature.hs | Registers the feature in the public API routing |
| libs/wire-api/src/Wire/API/Routes/Public/Galley/Feature.hs | Adds FeatureAPIGet route for AssetAuditLogConfig |
| services/galley/src/Galley/API/Internal.hs | Adds internal API support for the feature |
| libs/wire-api/src/Wire/API/Routes/Internal/Galley.hs | Defines internal feature API routing for AssetAuditLogConfig |
| libs/galley-types/src/Galley/Types/Teams.hs | Implements FeatureDefaults for AssetAuditLogConfig |
| integration/test/Test/FeatureFlags/AssetAuditLog.hs | Comprehensive test suite for the new feature flag |
| integration/test/Test/FeatureFlags/Util.hs | Updates test utilities to include the new feature |
| integration/integration.cabal | Registers the new test module |
| services/galley/galley.integration.yaml | Adds integration test configuration |
| hack/helm_vars/wire-server/values.yaml.gotmpl | Updates Helm template values |
| charts/galley/values.yaml | Adds default configuration values |
| charts/galley/templates/configmap.yaml | Updates Helm template to include the feature |
| docs/src/developer/reference/config-options.md | Documents the new feature flag |
| changelog.d/2-features/WPB-20206 | Adds changelog entry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
@copilot why haven't you approved this PR? |
This was referenced Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d