Skip to content

reject MLS messages while in epoch 0#4811

Merged
stefanwire merged 2 commits intodevelopfrom
sb/application-epoch-0
Dec 19, 2025
Merged

reject MLS messages while in epoch 0#4811
stefanwire merged 2 commits intodevelopfrom
sb/application-epoch-0

Conversation

@stefanwire
Copy link
Contributor

@stefanwire stefanwire commented Oct 9, 2025

https://wearezeta.atlassian.net/browse/WPB-20947

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@stefanwire stefanwire requested review from a team as code owners October 9, 2025 15:56
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 9, 2025
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stefanwire stefanwire force-pushed the sb/application-epoch-0 branch 2 times, most recently from b8f75fb to e167202 Compare November 18, 2025 09:32
@stefanwire stefanwire force-pushed the sb/application-epoch-0 branch from 05c1689 to a8098a0 Compare December 19, 2025 14:18
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor nitpick below.

Comment on lines +86 to +89
let (user, cid, other) =
if convOwnerDomain == otherDomain
then (bob, bob1, alice)
else (alice, alice1, bob)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get user out of cid, so you could just return a pair here.

@stefanwire stefanwire merged commit d1ecba6 into develop Dec 19, 2025
10 checks passed
@stefanwire stefanwire deleted the sb/application-epoch-0 branch December 19, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants