Conversation
zebot
added
the
ok-to-test
| parseText def | ||
| $ "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" | ||
| <> "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.1//EN\"" | ||
| <> " \"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd\">" | ||
| <> "<html xmlns=\"http://www.w3.org/1999/xhtml\" xml:lang=\"en\">" | ||
| <> "<body onload=\"document.forms[0].submit()\">" | ||
| <> "<noscript>" | ||
| <> "<p>" | ||
| <> "<strong>Note:</strong>Since your browser does not support JavaScript," | ||
| <> " you must press the Continue button once to proceed." | ||
| <> "</p>" | ||
| <> "</noscript>" | ||
| <> "<form action=\"https://ServiceProvider.com/SAML/SLO/Browser/%25%25\"" | ||
| <> " method=\"post\" accept-charset=\"utf-8\">" | ||
| <> "<input type=\"hidden\" name=\"SAMLRequest\"" | ||
| <> " value=\"PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz48c2FtbHA6TG9nb3V0UmVxdWVzdCBJRD0iZDJiN2MzODhjZWMzNmZhN2MzOWMyOGZkMjk4NjQ0YTgiIElzc3VlSW5zdGFudD0iMjAwNC0wMS0yMVQxOTowMDo0OVoiIFZlcnNpb249IjIuMCIgeG1sbnM6c2FtbHA9InVybjpvYXNpczpuYW1lczp0YzpTQU1MOjIuMDpwcm90b2NvbCI+ICAgIDxJc3N1ZXIgeG1sbnM9InVybjpvYXNpczpuYW1lczp0YzpTQU1MOjIuMDphc3NlcnRpb24iPmh0dHBzOi8vSWRlbnRpdHlQcm92aWRlci5jb20vU0FNTDwvSXNzdWVyPiAgICA8TmFtZUlEIEZvcm1hdD0idXJuOm9hc2lzOm5hbWVzOnRjOlNBTUw6Mi4wOm5hbWVpZC1mb3JtYXQ6cGVyc2lzdGVudCIgeG1sbnM9InVybjpvYXNpczpuYW1lczp0YzpTQU1MOjIuMDphc3NlcnRpb24iPjAwNWEwNmUwLWFkODItMTEwZC1hNTU2LTAwNDAwNWIxM2EyYjwvTmFtZUlEPiAgICA8c2FtbHA6U2Vzc2lvbkluZGV4PjE8L3NhbWxwOlNlc3Npb25JbmRleD48L3NhbWxwOkxvZ291dFJlcXVlc3Q+\"/>" | ||
| <> "<noscript>" | ||
| <> "<input type=\"submit\" value=\"Continue\"/>" | ||
| <> "</noscript>" | ||
| <> "</form>" | ||
| <> "</body>" | ||
| <> "</html>" |
There was a problem hiding this comment.
The linter doesn't seem to be happy with this: https://concourse.ops.zinfra.io/builds/113705858#L6925182b:20
Are you using Ormolu?
There was a problem hiding this comment.
oh no, the ormolu poltergeist from saml2-web-sso has re-emerged, and this time on another dev machine! i guess it's time to fix it?
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
Hard to approve changes while the CI is failing... 🤔
However, please feel free to get back to me on this. (I now know what this is about, so I might be quick in approving. 😉 )
| encode = Text.XML.renderText settings . renderToDocument | ||
| where | ||
| settings = def {rsNamespaces = nameSpaces (Proxy @a), rsXMLDeclaration = False} | ||
| settings = def {rsNamespaces = nameSpaces (Proxy @a), rsXMLDeclaration = True} |
There was a problem hiding this comment.
Either this should let some tests fail (CI is unfortunately blocked by the linting error) or one should be written 😉
There was a problem hiding this comment.
Looks like there is one meaningfully failling: https://concourse.ops.zinfra.io/builds/113707705#L69251a57:1358
There was a problem hiding this comment.
there was one failing test which i fixed (and thereby broke ormolu). why would you expect other tests to fail? any ones in particular? (i'm asking, but i really should be looking for some myself...)
There was a problem hiding this comment.
ah, found some more tests that fail! thanks concourse! :-)
3 participants
https://wearezeta.atlassian.net/browse/WPB-22287
Checklist
changelog.d