Skip to content

WPB-22168 [fix-up] set the defaults of the cells feature correctly#4907

Merged
battermann merged 2 commits intodevelopfrom
battermann/fix-up-default-cells-values
Dec 12, 2025
Merged

WPB-22168 [fix-up] set the defaults of the cells feature correctly#4907
battermann merged 2 commits intodevelopfrom
battermann/fix-up-default-cells-values

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Dec 12, 2025

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 12, 2025
@battermann battermann marked this pull request as ready for review December 12, 2025 09:43
@battermann battermann requested review from a team as code owners December 12, 2025 09:43
@battermann battermann requested a review from Copilot December 12, 2025 09:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a fix-up for WPB-22168 that corrects the default configuration values for the cells team feature flag. The title indicates this is a follow-up fix to ensure proper defaults are set.

Key Changes:

  • Changes the cells feature flag defaults from enabled/unlocked to disabled/locked
  • Updates the changelog entry to reference related PRs (#4889, #4907)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
charts/galley/values.yaml Corrects cells feature defaults to disabled/locked, aligning with the pattern used by most other feature flags
changelog.d/2-features/WPB-22168 Adds PR references to the changelog entry for traceability

The changes look correct and align with the established convention in the codebase where most feature flags default to status: disabled with lockStatus: locked. The cells feature (the public-facing feature) is now properly configured to be disabled and locked by default, while cellsInternal (the internal feature) remains enabled and unlocked as intended. The changelog update appropriately links to the related PRs for traceability.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@battermann battermann merged commit 0bfd8ff into develop Dec 12, 2025
16 checks passed
@battermann battermann deleted the battermann/fix-up-default-cells-values branch December 12, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants