Move code URI from ConversationCode to ConversationCodeInfo#4911
Merged
akshaymankar merged 1 commit intodevelopfrom Dec 16, 2025
Merged
Move code URI from ConversationCode to ConversationCodeInfo#4911akshaymankar merged 1 commit intodevelopfrom
akshaymankar merged 1 commit intodevelopfrom
Conversation
This is more semantically correct and allows us to guarantee that there will always be a URI returned with the code.
zebot
added
the
ok-to-test
akshaymankar
commented
Dec 16, 2025
| "code": "sEG3Y60tIsd9P3", | ||
| "key": "M0vnbETaqAgL8tv5Z1_x", | ||
| "uri": "https://example.com" | ||
| "key": "M0vnbETaqAgL8tv5Z1_x" |
Member
Author
There was a problem hiding this comment.
This looks like a breaking change, but this type is not used at top level of any API, so this is fine.
blackheaven
approved these changes
Dec 16, 2025
Contributor
blackheaven
left a comment
blackheaven
left a comment
There was a problem hiding this comment.
I wonder if it throws an error when the client puts the drop field in the payload.
Member
Author
Its never a request payload. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more semantically correct and allows us to guarantee that there will always be a URI returned with the code.
https://wearezeta.atlassian.net/browse/WPB-9010
Checklist
changelog.d