Skip to content

WPB-22811 Move CodeStore to wire-subsystems#4959

Merged
battermann merged 3 commits intodevelopfrom
WPB-22811-migrate-conversation-codes-table-to-postgres
Jan 16, 2026
Merged

WPB-22811 Move CodeStore to wire-subsystems#4959
battermann merged 3 commits intodevelopfrom
WPB-22811-migrate-conversation-codes-table-to-postgres

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Jan 15, 2026

Part 1 of https://wearezeta.atlassian.net/browse/WPB-22811

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 15, 2026
@battermann battermann marked this pull request as ready for review January 15, 2026 14:31
@battermann battermann requested review from a team as code owners January 15, 2026 14:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request moves the CodeStore effect and related data types from the galley service to the shared wire-subsystems library. This refactoring improves code organization by extracting conversation code functionality into a reusable subsystem that can be shared across services.

Changes:

  • Moved CodeStore effect from Galley.Effects.CodeStore to Wire.CodeStore
  • Moved Code and Scope data types from Galley.Data.* to Wire.CodeStore.*
  • Moved Cassandra implementation from Galley.Cassandra.Code to Wire.CodeStore.Cassandra
  • Updated all import statements across galley service to reference the new module locations

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
services/galley/src/Galley/Effects.hs Removed CodeStore export and added new imports for the moved types; added Input for convCodeURI configuration
services/galley/src/Galley/Cassandra/Queries.hs Removed code-related Cassandra queries (moved to wire-subsystems)
services/galley/src/Galley/App.hs Updated imports and added runInputConst for convCodeURI before CodeStore interpreter
services/galley/src/Galley/API/Util.hs Updated imports to reference Wire.CodeStore modules
services/galley/src/Galley/API/Update.hs Updated imports for CodeStore and Scope types
services/galley/src/Galley/API/Teams/Features.hs Added Wire.CodeStore import
services/galley/src/Galley/API/Teams.hs Added Wire.CodeStore import
services/galley/src/Galley/API/Query.hs Updated imports to use Wire.CodeStore.Code for Code type
services/galley/src/Galley/API/MLS/Util.hs Updated import to use Wire.StoredConversation
services/galley/src/Galley/API/Federation.hs Added Wire.CodeStore import
services/galley/src/Galley/API/Action.hs Updated imports for CodeStore and Scope types
services/galley/galley.cabal Removed Galley.Cassandra.Code, Galley.Data.Scope, Galley.Data.Types, and Galley.Effects.CodeStore
libs/wire-subsystems/wire-subsystems.cabal Added five new modules for CodeStore functionality
libs/wire-subsystems/src/Wire/CodeStore/Scope.hs New file containing Scope data type (moved from Galley.Data.Scope)
libs/wire-subsystems/src/Wire/CodeStore/Code.hs New file containing Code data type and related functions (extracted from Galley.Data.Types)
libs/wire-subsystems/src/Wire/CodeStore/Cassandra/Queries.hs New file with Cassandra queries for code storage (moved from Galley.Cassandra.Queries)
libs/wire-subsystems/src/Wire/CodeStore/Cassandra.hs New file with Cassandra interpreter for CodeStore (refactored from Galley.Cassandra.Code)
libs/wire-subsystems/src/Wire/CodeStore.hs Main CodeStore effect module (moved from Galley.Effects.CodeStore)
changelog.d/5-internal/WPB-22811 Added changelog entry documenting the move

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@battermann battermann merged commit 2524ba9 into develop Jan 16, 2026
17 checks passed
@battermann battermann deleted the WPB-22811-migrate-conversation-codes-table-to-postgres branch January 16, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants