Skip to content

[WPB-22793] GET /teams/:tid/apps#4960

Merged
fisx merged 3 commits intodevelopfrom
WPB-22793-get-apps
Jan 16, 2026
Merged

[WPB-22793] GET /teams/:tid/apps#4960
fisx merged 3 commits intodevelopfrom
WPB-22793-get-apps

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Jan 15, 2026

https://wearezeta.atlassian.net/browse/WPB-22793

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 15, 2026
@fisx fisx force-pushed the WPB-22793-get-apps branch from d95e219 to 13d2ab4 Compare January 15, 2026 21:47
@fisx fisx marked this pull request as ready for review January 15, 2026 21:47
@fisx fisx requested review from a team as code owners January 15, 2026 21:47
pure $ mkApp <$> matchAndZip storedApps us
where
matchAndZip :: [StoredApp] -> [StoredUser] -> [(StoredApp, StoredUser)]
matchAndZip as us = catMaybes $ f <$> as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ´Nothing` possible in practice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not legally, no: it would be an inconsistency between the cassandra user table and the postgres apps table.

i was thinking about this, and came to the conclusion that failing here and breaking app functionality seems an overly destructive way to flag the inconsistency.

@fisx fisx merged commit 179c862 into develop Jan 16, 2026
10 of 11 checks passed
@fisx fisx deleted the WPB-22793-get-apps branch January 16, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants