WPB-21964 follow-up: moved TeamFeatureStore interpreter to subsystems#4974
Merged
battermann merged 4 commits intodevelopfrom Jan 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the refactoring work started in WPB-21964 by moving the TeamFeatureStore Cassandra interpreter from the Galley service to the wire-subsystems library. This promotes better code organization and reusability by placing the interpreter alongside the effect definition.
Changes:
- Moved
Galley.Cassandra.TeamFeaturesmodule toWire.TeamFeatureStore.Cassandrain wire-subsystems - Introduced
TeamFeatureStoreErrortype to replace direct use ofInternalErrorin the interpreter - Removed TinyLog dependency from the interpreter (logging handled at higher application level)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| services/galley/src/Galley/App.hs | Updated imports, added error mapping function for TeamFeatureStoreError, and positioned error handler in effect stack |
| services/galley/galley.cabal | Removed Galley.Cassandra.TeamFeatures from exposed modules |
| libs/wire-subsystems/wire-subsystems.cabal | Added Wire.TeamFeatureStore.Cassandra module and constraints dependency |
| libs/wire-subsystems/src/Wire/TeamFeatureStore/Cassandra.hs | Moved and refactored module with new error type, removed TinyLog dependency, changed embedClient to embedClientInput |
| changelog.d/5-internal/WPD-21964 | Updated changelog entry with PR references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blackheaven
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d