Skip to content

WPB-21964 follow-up: moved TeamFeatureStore interpreter to subsystems#4974

Merged
battermann merged 4 commits intodevelopfrom
WPB-21964-move-team-feature-store-interpreter
Jan 22, 2026
Merged

WPB-21964 follow-up: moved TeamFeatureStore interpreter to subsystems#4974
battermann merged 4 commits intodevelopfrom
WPB-21964-move-team-feature-store-interpreter

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Jan 22, 2026

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann marked this pull request as ready for review January 22, 2026 11:43
@battermann battermann requested review from a team as code owners January 22, 2026 11:43
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 22, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the refactoring work started in WPB-21964 by moving the TeamFeatureStore Cassandra interpreter from the Galley service to the wire-subsystems library. This promotes better code organization and reusability by placing the interpreter alongside the effect definition.

Changes:

  • Moved Galley.Cassandra.TeamFeatures module to Wire.TeamFeatureStore.Cassandra in wire-subsystems
  • Introduced TeamFeatureStoreError type to replace direct use of InternalError in the interpreter
  • Removed TinyLog dependency from the interpreter (logging handled at higher application level)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
services/galley/src/Galley/App.hs Updated imports, added error mapping function for TeamFeatureStoreError, and positioned error handler in effect stack
services/galley/galley.cabal Removed Galley.Cassandra.TeamFeatures from exposed modules
libs/wire-subsystems/wire-subsystems.cabal Added Wire.TeamFeatureStore.Cassandra module and constraints dependency
libs/wire-subsystems/src/Wire/TeamFeatureStore/Cassandra.hs Moved and refactored module with new error type, removed TinyLog dependency, changed embedClient to embedClientInput
changelog.d/5-internal/WPD-21964 Updated changelog entry with PR references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@battermann battermann merged commit c8c6ae3 into develop Jan 22, 2026
11 checks passed
@battermann battermann deleted the WPB-21964-move-team-feature-store-interpreter branch January 22, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants