Add --skip-tables=<tables> argument to exclude tables when performing search-replace
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
requested changes
Dec 3, 2017
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks @marksabbath !
Can you include functional tests for this change?
Contributor
Author
|
Added functional tests @danielbachhuber as you've requested. |
danielbachhuber
changed the title
--skip-tables=<tables> argument to exclude tables when performing search-replace
Restrict some search-replace tests to wp_posts to avoid wp_options cl…
Member
|
@marksabbath Can you merge master for #49? |
Contributor
Author
|
Done by 282570e @danielbachhuber |
danielbachhuber
approved these changes
Dec 4, 2017
gitlost
reviewed
Dec 4, 2017
|
|
||
| foreach ( $tables as $table ) { | ||
|
|
||
| if ( in_array( $table, $this->skip_tables ) ) { |
Contributor
There was a problem hiding this comment.
Just to note that this wasn't removed when the array_diff() was added and made it redundant.
danielbachhuber
added a commit
that referenced
this pull request
Nov 18, 2022
Add `--skip-tables=<tables>` argument to exclude tables when performing search-replace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #31
--skip-tables