Conversation
okuryu
approved these changes
Jun 21, 2021
Collaborator
okuryu
left a comment
okuryu
left a comment
There was a problem hiding this comment.
Thanks. Let's put this in.
Collaborator
|
published v6.0.0. |
nevilm-lt
pushed a commit
to SynapseTestOrg/serialize-javascript
that referenced
this pull request
Apr 22, 2022
himanshiLt
pushed a commit
to himanshiLt/serialize-javascript
that referenced
this pull request
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
This PR adds support for the built-in URL type. This is supported everywhere
SetandMapare supported so I don't think compatibility should be an issue.As far as how the actual value is serialized: the string-ified URL value itself is not escaped because
URLwill do this for us e.g.(new URL("https://script>.com")).toString()➡️"https://script%3E.com/".