Skip to content

Use BITOPS_PLUGINS_DIR to fix the plugin unable to find the deployment scripts#7

Merged
LeoDiazL merged 2 commits intomainfrom
fix-plugin-script-dir
Nov 29, 2022
Merged

Use BITOPS_PLUGINS_DIR to fix the plugin unable to find the deployment scripts#7
LeoDiazL merged 2 commits intomainfrom
fix-plugin-script-dir

Conversation

@mickmcgrath13
Copy link
Copy Markdown
Contributor

@mickmcgrath13 mickmcgrath13 commented Nov 29, 2022

Clean up seemingly unused code (namely scripts/deploy.sh), and use the correct reference for bitops installed plugins (from bitovi/bitops#347).

Error:

+ bash /opt/bitops/scripts/plugins/ansible/scripts/validate_env.sh
bash: /opt/bitops/scripts/plugins/ansible/scripts/validate_env.sh: No such file or directory
+ echo 'Running Ansible Playbooks'
Running Ansible Playbooks
+ bash -x /opt/bitops/scripts/plugins/ansible/scripts/ansible_install_playbooks.sh ''
bash: /opt/bitops/scripts/plugins/ansible/scripts/ansible_install_playbooks.sh: No such file or directory

@arm4b arm4b added the bug Something isn't working label Nov 29, 2022
@arm4b arm4b changed the title Use BITOPS_PLUGINS_DIR Use BITOPS_PLUGINS_DIR to fix the plugin unable to find the deployment scripts Nov 29, 2022
deploy.sh Outdated
fi

bash $SCRIPTS_DIR/plugins/ansible/scripts/validate_env.sh
bash $BITOPS_PLUGINS_DIR/ansible/scripts/validate_env.sh
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be

bash $BITOPS_INSTALLED_PLUGIN_DIR/scripts/validate_env.sh

deploy.sh Outdated
bash -x $SCRIPTS_DIR/plugins/ansible/scripts/ansible_install_playbooks.sh "$BITOPS_CONFIG_COMMAND"

# bash $SCRIPTS_DIR/deploy/after-deploy.sh "$ANSIBLE_ROOT"
bash -x $BITOPS_PLUGINS_DIR/ansible/scripts/ansible_install_playbooks.sh "$BITOPS_CONFIG_COMMAND"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be

bash -x $BITOPS_INSTALLED_PLUGIN_DIR/scripts/ansible_install_playbooks.sh "$BITOPS_CONFIG_COMMAND"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Copy link
Copy Markdown

@LeoDiazL LeoDiazL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked. Working OK.

@LeoDiazL LeoDiazL merged commit bb1c588 into main Nov 29, 2022
@LeoDiazL LeoDiazL deleted the fix-plugin-script-dir branch November 29, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants