Skip to content

add pass through of CFN_CAPABILITY if set via BITOPS_CFN_CAPABILITY#5

Merged
arm4b merged 1 commit intobitops-plugins:mainfrom
rwubafs:fix/pass-through-cfn-capability
Oct 4, 2022
Merged

add pass through of CFN_CAPABILITY if set via BITOPS_CFN_CAPABILITY#5
arm4b merged 1 commit intobitops-plugins:mainfrom
rwubafs:fix/pass-through-cfn-capability

Conversation

@rwubafs
Copy link
Copy Markdown

@rwubafs rwubafs commented Oct 4, 2022

This prevents CFN_CAPABILITY from silently being passed down to cloudformation_deploy.sh subscript as an empty string

Closes #4

Copy link
Copy Markdown
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for finding the bug #4 and even fixing it! 👍

@arm4b arm4b merged commit 75806d9 into bitops-plugins:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deploy.sh does not export CFN_CAPABILITY on dockerhub's bitovi/bitops:latest

2 participants