Skip to content

Update placement of stack-action from 'options' to 'cli'#17

Merged
arm4b merged 2 commits intomainfrom
cli-option-fix
Nov 21, 2022
Merged

Update placement of stack-action from 'options' to 'cli'#17
arm4b merged 2 commits intomainfrom
cli-option-fix

Conversation

@PhillypHenning
Copy link
Copy Markdown
Contributor

@PhillypHenning PhillypHenning commented Nov 10, 2022

Small update to stack-action, removed from options and put into cli ....

Closes bitovi/bitops#227
Closes #18

Copy link
Copy Markdown
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will also need a README update

https://github.com/bitops-plugins/terraform#cli-and-options-configuration-of-terraform-bitopsschemayaml

and bitops.sh docs

Otherwise, the change makes sense. Looks like Cloudformation is defining it in the CLI too as @LeoDiazL mentioned.

@arm4b arm4b added breaking change enhancement New feature or request labels Nov 10, 2022
@arm4b
Copy link
Copy Markdown
Member

arm4b commented Nov 10, 2022

@PhillypHenning Once merged, will it be a breaking change for the users?
To keep in mind for the migration instructions.

@PhillypHenning
Copy link
Copy Markdown
Contributor Author

Yes... it will have impact if people are using that configuration value, however, we need to standardize its placement across the plugins.

So; The sooner the better for the change.

The doc is being updated in tandem, but this isn't something I was actively working on, just noting.

@arm4b arm4b changed the title Updating placement of stack-action Updating placement of stack-action from 'options' to 'cli' Nov 17, 2022
@arm4b arm4b changed the title Updating placement of stack-action from 'options' to 'cli' Update placement of stack-action from 'options' to 'cli' Nov 17, 2022
@PhillypHenning PhillypHenning requested a review from arm4b November 21, 2022 16:38
@arm4b
Copy link
Copy Markdown
Member

arm4b commented Nov 21, 2022

The PR looks good, we'll also need an official documentation update in the bitops.sh.
So ideally, if we could merge those changes in one go.

@PhillypHenning
Copy link
Copy Markdown
Contributor Author

BitOps core doc updated bitovi/bitops#363

@arm4b arm4b merged commit ce701be into main Nov 21, 2022
@arm4b arm4b deleted the cli-option-fix branch November 21, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize plugin configuration values BitOps Schema Config Variables Consistancy

3 participants