Conversation
|
|
||
| ### Python Style guide | ||
|
|
||
| * Use 4 spaces for a tab. |
Contributor
There was a problem hiding this comment.
Put this into the Coding Conventions section
Contributor
Author
There was a problem hiding this comment.
There is an outdated section "Coding Conventions" that was probably relevant to bash in the previous BitOps v1:
https://bitovi.github.io/bitops/contributing/#coding-conventions
That section was removed in this PR.
There is another section for bash and yaml formatting under the development page:
https://bitovi.github.io/bitops/development/development/#bash-style-guide
I propose to have only one place for the coding standards under development.md page to avoid confusion with scattered guidelines.
PhillypHenning
approved these changes
Sep 6, 2022
| # 4. ERROR | ||
|
|
||
| from .settings import BITOPS_logging_level, BITOPS_logging_color, BITOPS_logging_filename, BITOPS_logging_path | ||
| from .settings import ( |
Contributor
There was a problem hiding this comment.
Nifty, didn't know this was possible
mickmcgrath13
approved these changes
Sep 6, 2022
arm4b
changed the title
This was referenced Sep 8, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
blacktool which enforces code formatting according to the common python standards.See https://black.readthedocs.io/en/stable/
It's the start of a future series of PRs focused on improving the codebase standards, adding tests, and enforcing the CI checks that are expected from the project with the python codebase. See https://github.com/bitovi/bitops/projects/4 project. Partially implements #271
black- code reformatting tooltox- pipeline/venv test runnertest-requirements.txtblackblackin CI GH Actions for every PRExample quick start instructions: