Exit with error when bitops.config.yaml not found#311
Merged
Conversation
Contributor
PhillypHenning
left a comment
There was a problem hiding this comment.
This is great, thank you for doing this so quickly.
Is it worth moving the description to the doc lookup file?
Contributor
Author
|
@PhillypHenning I think the lookup thing is outside of this PR scope as we want a fix which stops the code execution early in case of no config file provided. If we want to switch into docs lookup way, we need to create a dedicated PR to go through all the errors, move them into lookup json and integrate into the docs so it works as one complete feature. Before the docs integration there's no value as it's harder to navigate the actual error from the code. |
6 tasks
PhillypHenning
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #310