Fix plugin deploy to respect return code from invoked bash scripts

[PhillypHenning]

Description

Updates the run_cmd function in utilities.py to respect the invoked bash script return code

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This was tested locally by building a local bitops and mounting my local terraform plugin with the update to the plugin deploy.sh that makes it exit 1

Logs

+ exit 1
2022-12-07 17:27:54,304 root         ERROR <subprocess.Popen object at 0x7f59e1395be0>

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation

[PhillypHenning]

fixes #358

[arm4b]

Considering we can only report error like this in the function itself, it's not helpful:

2022-12-07 17:27:54,304 root ERROR <subprocess.Popen object at 0x7f59e1395be0>

The error handling and reporting should be done on another layer, - code that's using this function. The function run_cmd returns a subprocess.CompletedProcess instance to be handled in next steps.

Here is the spot that might be missing an exit:

bitops/scripts/plugins/deploy_plugins.py

Lines 271 to 281 in 5b0fec0

	result = run_cmd(
	[
	plugin_deploy_language,
	plugin_deploy_script_path,
	stack_action,
	]
	)
	if result.returncode == 0:
	logger.info(f"\n~#~#~#~DEPLOYING OPS REPO [{deployment}] SUCCESSFULLY COMPLETED~#~#~#~")
	else:
	logger.warning(f"\n~#~#~#~DEPLOYING OPS REPO [{deployment}] FAILED~#~#~#~")

[arm4b]

Looks good, thanks for the bug fixes 👍

[PhillypHenning]

Reason for auto-merge cancel
The effort of reworking install_plugins is way beyond this tickets scope.