Skip to content

Fix BitOps to pass lowercase booleans based on plugin schema defaults#379

Merged
arm4b merged 1 commit intomainfrom
357-bitops-plugins-should-receive-lowercase-bool-values
Dec 14, 2022
Merged

Fix BitOps to pass lowercase booleans based on plugin schema defaults#379
arm4b merged 1 commit intomainfrom
357-bitops-plugins-should-receive-lowercase-bool-values

Conversation

@LeoDiazL
Copy link
Copy Markdown
Contributor

@LeoDiazL LeoDiazL commented Dec 14, 2022

Description

Values returned to BitOps plugins parsed from the config schema are being returned with uppercase booleans (true -> True), while the lowercase is expected.

Fixes #357

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Live session

@LeoDiazL LeoDiazL linked an issue Dec 14, 2022 that may be closed by this pull request
@LeoDiazL LeoDiazL requested a review from arm4b December 14, 2022 19:47
@arm4b arm4b added this to the v2.3.0 milestone Dec 14, 2022
@arm4b arm4b added the bug 🪲 Something isn't working label Dec 14, 2022
@arm4b arm4b changed the title Returning values as lowercase booleans Fix BitOps to pass lowercase booleans based on plugin schema defaults Dec 14, 2022
Copy link
Copy Markdown
Contributor

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! 👍

@arm4b arm4b merged commit df97890 into main Dec 14, 2022
@arm4b arm4b deleted the 357-bitops-plugins-should-receive-lowercase-bool-values branch December 14, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🪲 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BitOps plugins should receive lowercase bool values

2 participants