Skip to content

Updating terraform doc with targets attribute#395

Merged
PhillypHenning merged 7 commits intomainfrom
terraform-target
Feb 17, 2023
Merged

Updating terraform doc with targets attribute#395
PhillypHenning merged 7 commits intomainfrom
terraform-target

Conversation

@PhillypHenning
Copy link
Copy Markdown
Contributor

@PhillypHenning PhillypHenning commented Feb 1, 2023

Doc update for terraform source-target attribute support

@runforesight
Copy link
Copy Markdown

runforesight bot commented Feb 1, 2023

Foresight Summary

Image Image Image Image 
Major Impacts
Foresight hasn't detected any major impact on your workflows and tests.

View More Details

✅  CI workflow has finished in 38 seconds and finished at 17th Feb, 2023.


Job Failed Steps Tests
lint-pylint -     🔗  N/A See Details
lint-black -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@PhillypHenning PhillypHenning changed the title Updating terraform doc Updating terraform doc with targets attribute Feb 1, 2023
@PhillypHenning
Copy link
Copy Markdown
Contributor Author

Neat 👍

@PhillypHenning PhillypHenning requested a review from arm4b February 1, 2023 23:57
Copy link
Copy Markdown
Contributor

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PhillypHenning PhillypHenning merged commit fade109 into main Feb 17, 2023
@PhillypHenning PhillypHenning deleted the terraform-target branch February 17, 2023 17:19
@arm4b arm4b added this to the v2.4.0 milestone Feb 17, 2023
Comment on lines +201 to +203
export_env = "BITOPS_" + export_env
os.environ[export_env] = str(value)
logger.info(f"Setting environment variable: [{export_env}], to value: [{value}]")
Copy link
Copy Markdown
Contributor

@arm4b arm4b Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing new bitops:dev image and the bug led me to this code.

Looks like it messed the changes #403

Probably a merge conflict

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix in #408

arm4b added a commit that referenced this pull request Feb 17, 2023
arm4b added a commit that referenced this pull request Feb 20, 2023
Fix ENV export prefix regression in #395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants