Skip to content

Adding environment variable check, if found ignore bitops.config attr…#396

Merged
PhillypHenning merged 5 commits intomainfrom
fix_371
Feb 7, 2023
Merged

Adding environment variable check, if found ignore bitops.config attr…#396
PhillypHenning merged 5 commits intomainfrom
fix_371

Conversation

@PhillypHenning
Copy link
Copy Markdown
Contributor

Adding environment variable check, if found ignore bitops.config attribute w/warning

Fixes # (issue)
Fixes #371

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes and post the logs from the local testing that are relevant. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Logs
Isolated into script for testing;

[Bitovi] [bitops] $ export TEST_371=true; python3 test.py
Please enter a value: TEST
Unable to find environment variable: [TEST]
Please enter a value: TEST_371
Environment Varible alredy set. Configuration value ignored.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@runforesight
Copy link
Copy Markdown

runforesight bot commented Feb 6, 2023

Foresight Summary

Image Image Image Image 
Major Impacts
Foresight hasn't detected any major impact on your workflows and tests.

View More Details

✅  CI workflow has finished in 48 seconds and finished at 7th Feb, 2023.


Job Failed Steps Tests
lint-black -     🔗  N/A See Details
lint-pylint -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@PhillypHenning PhillypHenning requested a review from arm4b February 6, 2023 21:25
Copy link
Copy Markdown
Contributor

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a typo fix and black reformat.

Besides that, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENV variables are not taking precedence over the plugin config (schema)

3 participants