Adding environment variable check, if found ignore bitops.config attr…#396
Merged
PhillypHenning merged 5 commits intomainfrom Feb 7, 2023
Merged
Adding environment variable check, if found ignore bitops.config attr…#396PhillypHenning merged 5 commits intomainfrom
PhillypHenning merged 5 commits intomainfrom
Conversation
Foresight Summary
View More Details✅ CI workflow has finished in 48 seconds and finished at 7th Feb, 2023.
*You can configure Foresight comments in your organization settings page. |
6004b8d to
34ea040
Compare
arm4b
suggested changes
Feb 6, 2023
arm4b
reviewed
Feb 6, 2023
arm4b
approved these changes
Feb 6, 2023
Contributor
arm4b
left a comment
There was a problem hiding this comment.
Needs a typo fix and black reformat.
Besides that, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding environment variable check, if found ignore bitops.config attribute w/warning
Fixes # (issue)
Fixes #371
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes and post the logs from the local testing that are relevant. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Logs
Isolated into script for testing;
Checklist: