Merged
Conversation
mickmcgrath13
requested changes
Feb 1, 2021
Closed
dylan-bitovi
approved these changes
Feb 3, 2021
Contributor
dylan-bitovi
left a comment
There was a problem hiding this comment.
I've been playing around with this and hashing it out with Connor over Slack. Everything looks good to me :)
mickmcgrath13
approved these changes
Feb 8, 2021
mickmcgrath13
requested changes
Mar 10, 2021
Contributor
mickmcgrath13
left a comment
There was a problem hiding this comment.
Let's get this hooked up prior to merging:
https://docs.docker.com/engine/reference/builder/#onbuild
…uirements The plugins-base ONBUILD stage should require `bitops.config.yaml` file only per plugins documentation so users can build their own BitOps image
It's replaced by the publish-docs.yaml for the `main` branch
* Fix 'disbatch' -> 'dispatch' typo in the CD workflows * Additional image tagging for ':latest', ':dev', and ':base' * Additional image tagging for ':latest', ':dev', and ':base' * Adjust the base workflow with additional release tag * Remove the 'v' prefix from the v1.2.3 for docker tagging * Match image tag that ends with 'omnibus'
* Fix plugins install not returning correct exit code on failure Fixes #239 * Use the proper logger.error on a plugin failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin implementation using Python (#54)
Overview
If
plugin.config.yml(new file) is as followsThen on
docker build,scripts/setup/install_plugins.pyis called togit clonethefav-colorrepo toscripts/plugins/fav-color/scripts/plugins/fav-color/install.shif it existsDuring BitOps execution,
$SCRIPTS_DIR/plugins/deploy.pyis called to loop through all plugins and:PLUGIN_DIRandENVIRONMENT_DIR$PLUGIN_DIR/bitops.schema.yamland$ENVIRONMENT_DIR/bitops.config.yamlCLI_OPTIONSscripts/plugins/fav-color/deploy.shTesting
Docker Build
We can see in the
docker build -t temp .log, thatRuntime
Operations Repo
My operations repo contains only 1 file
test/fav-color/bitops.config.yaml:BitOps execution (truncated):
We can see that