Skip to content

Allow users to configure DockerHub for use with containers#11332

Merged
jamesopstad merged 14 commits intomainfrom
nsharma/docker
Mar 3, 2026
Merged

Allow users to configure DockerHub for use with containers#11332
jamesopstad merged 14 commits intomainfrom
nsharma/docker

Conversation

@nikitassharma
Copy link
Member

@nikitassharma nikitassharma commented Nov 18, 2025

Fixes CC-6468

Allows users to configure DockerHub credentials and then create containers with images stored there.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: needs some internal improvements before docs are added

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@nikitassharma nikitassharma requested review from a team as code owners November 18, 2025 18:08
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

🦋 Changeset detected

Latest commit: b092740

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main nsharma/docker might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11332
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 18, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11332

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11332

miniflare

npm i https://pkg.pr.new/miniflare@11332

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11332

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11332

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11332

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11332

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11332

wrangler

npm i https://pkg.pr.new/wrangler@11332

commit: 2daf35e

ichernetsky-cf
ichernetsky-cf previously approved these changes Nov 19, 2025
gpanders
gpanders previously approved these changes Nov 19, 2025
emily-shen
emily-shen previously approved these changes Nov 19, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 19, 2025
@petebacondarwin
Copy link
Contributor

@nikitassharma can you rebase and fix the conflicts please.

@petebacondarwin petebacondarwin marked this pull request as draft December 23, 2025 12:18
@nikitassharma
Copy link
Member Author

@nikitassharma can you rebase and fix the conflicts please.

@petebacondarwin I'll leave this as a draft for now. There are some issues I'm seeing internally with this that I need to resolve before merging, and likely won't get to it for a bit.

@workers-devprod workers-devprod dismissed stale reviews from emily-shen and gpanders March 2, 2026 18:26

Changes in owned files since last approval

@workers-devprod workers-devprod dismissed ichernetsky-cf’s stale review March 2, 2026 18:26

Changes in owned files since last approval

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

✅ All changesets look good

@nikitassharma nikitassharma marked this pull request as ready for review March 2, 2026 18:29
@workers-devprod
Copy link
Contributor

workers-devprod commented Mar 2, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@nikitassharma
Copy link
Member Author

@nikitassharma can you rebase and fix the conflicts please.

@petebacondarwin I'll leave this as a draft for now. There are some issues I'm seeing internally with this that I need to resolve before merging, and likely won't get to it for a bit.

errors have been resolved, change is ready for review

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

emily-shen
emily-shen previously approved these changes Mar 3, 2026
@workers-devprod workers-devprod dismissed emily-shen’s stale review March 3, 2026 15:12

Changes in owned files since last approval

@jamesopstad jamesopstad merged commit 6a8aa5f into main Mar 3, 2026
52 of 61 checks passed
@jamesopstad jamesopstad deleted the nsharma/docker branch March 3, 2026 17:55
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants