engine: add recursive bind mounts#18669
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
force-pushed
the
recursive-ro-bind-mounts
branch
from
8e78526 to
9f6852d
Compare
dvdksn
force-pushed
the
recursive-ro-bind-mounts
branch
from
9f6852d to
53d7ffd
Compare
dvdksn
added
the
status/do-not-merge
content/storage/bind-mounts.md
Outdated
|
|
||
| `bind-recursive=readonly` | ||
| : Enables recursive bind-mounts. | ||
| Submounts are read-only. |
There was a problem hiding this comment.
Perhaps we should mention that this produces an error if the kernel or doesn't support this feature (kernel versions older than v5.12).
| read-only mounts. Recursive read-only mounts require Linux kernel version 5.12 | ||
| or later. If you're running an older kernel version, submounts are |
There was a problem hiding this comment.
Actually wondering now; what do we do for native Windows containers, @AkihiroSuda ? Do we produce an error, or do we silently ignore the options (or a warning?)
Is there an equivalent of submounts on Windows? (and are they inherited?) 🤔
There was a problem hiding this comment.
Yeah; wondering if Windows in any form inherits nested mounts. I can try asking around for someone to try.
If it doesn't, then ignoring is probably fine (we could print a warning in some cases I guess, but more complicated on docker run, because we can't mix those with the container's own output)
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
recursive-ro-bind-mounts
branch
from
53d7ffd to
2d55bac
Compare
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM! But leaving a "request changes" as we need to wait for v25.0 to be released before we publish 😅
thaJeztah
removed
the
status/do-not-merge
4 participants
bind-recursivemount option cli#4606https://deploy-preview-18669--docsdocker.netlify.app/storage/bind-mounts/#recursive-mounts