fix: ignore directory listing entry for the iterated directory#8921
Merged
fix: ignore directory listing entry for the iterated directory#8921
Conversation
The `ignoreFirst` bool had a short lifetime, by the time the lambda slot handling the `LsColJob::directoryListingIterated` signal was called the reference to that bool would report a completely different value. This could result in the first entry of a directory listing to not be ignored properly. This commit changes the way the slot checks whether it's currently iterating over the very same directory that was just requested by comparing the request path with the path from the response. Fixes #8915 Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
requested review from
Aiiaiiio,
camilasan,
i2h3 and
mgallien
as code owners
Member
Author
|
/backport to stable-4.0 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-8921.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
camilasan
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ignoreFirstbool had a short lifetime, by the time the lambda slot handling theLsColJob::directoryListingIteratedsignal was called the reference to that bool would report a completely different value. This could result in the first entry of a directory listing to not be ignored properly.This commit changes the way the slot checks whether it's currently iterating over the very same directory that was just requested by comparing the request path with the path from the response.
Fixes #8915