Fix Crash on File Provider Deactivation for Account with UUID Name#8941
Fix Crash on File Provider Deactivation for Account with UUID Name#8941
Conversation
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
requested review from
Aiiaiiio,
camilasan,
mgallien and
nilsding
as code owners
i2h3
added
bug
feature: 📁 file provider
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash that occurs when deactivating the File Provider for accounts with UUID names. The fix removes unnecessary assertions and improves code clarity around domain ID and account ID handling.
Key changes:
- Renamed
configuredDomainIds()togetAccountIdsOfFoundFileProviderDomains()and updated related variable names for clarity - Removed
accountIdFromDomainId()conversion call in cleanup logic, treating domain IDs as account IDs directly - Removed unnecessary account null assertions that could cause crashes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/gui/macOS/fileproviderdomainmanager_mac.mm | Renamed method and variables for clarity, simplified domain cleanup logic by treating domain IDs as account IDs, and removed assertions that could cause crashes |
| shell_integration/MacOSX/NextcloudIntegration/NextcloudIntegration.xcodeproj/project.pbxproj | Updated Xcode project configuration with new object version and file system synchronized root group |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/backport to stable-4.0 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-8941.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
No description provided.