Conversation
i2h3
requested review from
Aiiaiiio,
camilasan,
mgallien and
nilsding
as code owners
i2h3
added
the
feature: 📁 file provider
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
i2h3
force-pushed
the
feature/9007-file-provider-database
branch
from
7514eb1 to
5bf76e6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the file provider utility functions by extracting a common helper function and extends debug archive functionality to include database files. The changes improve code reusability and enhance debugging capabilities by collecting .realm database files from file provider domains.
- Extracted
fileProviderDomainsSupportDirectory()as a shared helper function - Refactored
fileProviderDomainSupportDirectory()to use the new helper - Added functionality to include
.realmdatabase files in debug archives
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/gui/macOS/fileproviderutils.h | Added declaration for new helper function fileProviderDomainsSupportDirectory() |
| src/gui/macOS/fileproviderutils_mac.mm | Extracted common directory navigation logic into fileProviderDomainsSupportDirectory() and refactored existing function to reuse it |
| src/gui/generalsettings.cpp | Added logic to collect and archive .realm database files from file provider domains |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…9007). Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
force-pushed
the
feature/9007-file-provider-database
branch
from
5bf76e6 to
989d8ac
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9016.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
/backport to stable-4.0 |
github-project-automation
bot
moved this from 🧭 Planning evaluation (don't pick)
to ☑️ Done
in 💻 Desktop Clients team
|
Needs a back port to stable-4.0 after passing and approval.