Skip to content

Bugfix/mgallien/noid/clazy fixes#9203

Merged
nilsding merged 2 commits intomasterfrom
bugfix/mgallien/noid/clazyFixes
Dec 9, 2025
Merged

Bugfix/mgallien/noid/clazy fixes#9203
nilsding merged 2 commits intomasterfrom
bugfix/mgallien/noid/clazyFixes

Conversation

@mgallien
Copy link
Copy Markdown
Collaborator

@mgallien mgallien commented Dec 8, 2025

No description provided.

@mgallien mgallien added this to the 4.1.0 milestone Dec 8, 2025
@mgallien
Copy link
Copy Markdown
Collaborator Author

mgallien commented Dec 8, 2025

should be done via CI and not by me when I think about it
that set of changes had been waiting since some time on a local branch
was planning to do more but would be useful as is

@mgallien @nilsding
chore: use clazy static code checker to improve the code
6a52b9a 
fix all occurence of this check
https://github.com/KDE/clazy/blob/master/docs/checks/README-fully-qualified-moc-types.md

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien @nilsding
chore: do not ignore returned value of KZip::open
a49691e 
fix warning about returned value being ignored

should make it clearer if that function fails in production use

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@nilsding nilsding force-pushed the bugfix/mgallien/noid/clazyFixes branch from 0864fa5 to a49691e Compare December 9, 2025 12:43
@nilsding nilsding enabled auto-merge December 9, 2025 12:43
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-9203.zip

Digest: sha256:6eb39edd7e4b9e76bf17d875679de98a22ad2bb061d16573b9268115033f8be8

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding nilsding merged commit dbea679 into master Dec 9, 2025
21 checks passed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
Image 0.0% Coverage on New Code (required ≥ 80%)
Image 92 New Code Smells (required ≤ 0)
Image E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

@nilsding nilsding deleted the bugfix/mgallien/noid/clazyFixes branch December 9, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

33.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mgallien @nilsding