Skip to content

Check for existence of a directory to remove before attempting to do so#9288

Merged
mgallien merged 1 commit intomasterfrom
i2h3/fix/crafter-rm
Jan 5, 2026
Merged

Check for existence of a directory to remove before attempting to do so#9288
mgallien merged 1 commit intomasterfrom
i2h3/fix/crafter-rm

Conversation

@i2h3
Copy link
Copy Markdown
Collaborator

@i2h3 i2h3 commented Jan 5, 2026 •
edited
Loading

Fixes our CI, too.

@i2h3
fix(mac-crafter): Check for existence of a directory to remove before…
e1bbb70 
… attempting to do so.

Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
Copilot AI review requested due to automatic review settings January 5, 2026 14:04
@i2h3 i2h3 changed the title fix(mac-crafter): Check for existence of a directory to remove before… Check for existence of a directory to remove before attempting to do so Jan 5, 2026
@i2h3 i2h3 self-assigned this Jan 5, 2026
@i2h3 i2h3 added bug os: 🍎 macOS Apple macOS, formerly also known as OS X CI build/checks continuous integration, Drone, testing labels Jan 5, 2026
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team Jan 5, 2026
@i2h3 i2h3 added this to the 4.1.0 milestone Jan 5, 2026
@i2h3 i2h3 moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team Jan 5, 2026
Copilot AI reviewed Jan 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the robustness of the build process by checking for the existence of the client build directory before attempting to remove it during a full rebuild. This prevents potential errors when the directory doesn't exist.

Key changes:

  • Added fileExists(atPath:) check before attempting to remove the client build directory
  • Added informative logging when the directory is being removed
  • Simplified error handling to focus on the removal failure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2026

Artifact containing the AppImage: nextcloud-appimage-pr-9288.zip

Digest: sha256:5adb672e5bb74dff1f951bdecd752bdc869c3afea9b5bef05765becb20f3a31d

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 5, 2026

Quality Gate Passed Quality Gate passed

Issues
Image 0 New issues
Image 0 Accepted issues

Measures
Image 0 Security Hotspots
Image 0.0% Coverage on New Code
Image 0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mgallien mgallien enabled auto-merge January 5, 2026 14:46
@mgallien mgallien merged commit dda8145 into master Jan 5, 2026
30 checks passed
@mgallien mgallien deleted the i2h3/fix/crafter-rm branch January 5, 2026 15:07
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mgallien mgallien mgallien approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

Assignees

@i2h3 i2h3

Labels

bug CI build/checks continuous integration, Drone, testing os: 🍎 macOS Apple macOS, formerly also known as OS X

Projects

None yet

Milestone

33.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@i2h3 @mgallien @Rello