Conversation
25d8a61 to
ab925dd
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a comprehensive logging system for mac-crafter that replaces direct print() statements with a centralized logging facility. The new system simultaneously writes to standard output, the macOS unified logging system, and a log file in ~/Library/Logs/mac-crafter.
Key Changes:
- Introduces a new
Logactor withinfo()anderror()methods for centralized logging - Enhances Shell.swift to capture and route child process stdout/stderr through the logging system
- Updates all direct
print()calls throughout the codebase to use the new logging API
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| admin/osx/mac-crafter/Sources/Log.swift | New logging facility implementation with file, console, and unified logging system support |
| admin/osx/mac-crafter/Sources/Utils/Shell.swift | Added pipe-based output capture to route child process output through logging system |
| admin/osx/mac-crafter/Sources/Utils/Signer.swift | Replaced print() calls with Log.info() for signing operations |
| admin/osx/mac-crafter/Sources/Utils/Packaging.swift | Converted print statements to Log.info and improved error message terminology |
| admin/osx/mac-crafter/Sources/Utils/Install.swift | Updated installation messages to use Log.info |
| admin/osx/mac-crafter/Sources/Commands/Build.swift | Migrated print/error messages to Log.info/error throughout build workflow |
| admin/osx/mac-crafter/README.md | Updated title and added troubleshooting section documenting the new logging system |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Write to standard output in terminal environment. - Write to unified logging system. - Write to log file. - All simultaneously. - Standard output and errors from child processes launched are captured, too. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
ab925dd to
0d976ef
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9290.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|



~/Library/Logs/mac-crafter).