Skip to content

feat(tray): sync status indicator in account menu#9427

Merged
Rello merged 14 commits intomasterfrom
codex/add-sync-status-overlay-to-user-avatars
Feb 16, 2026
Merged

feat(tray): sync status indicator in account menu#9427
Rello merged 14 commits intomasterfrom
codex/add-sync-status-overlay-to-user-avatars

Conversation

@Rello
Copy link
Copy Markdown
Collaborator

@Rello Rello commented Feb 5, 2026

Motivation

  • The sync status overlay on the avatar conflicted with the user presence indicator and was visually confusing.
  • Sync attention indicators should be scanable in the account list and not obscure the avatar, and the menu needs a bit more width to accommodate an extra column.

Description

  • Moved the per-account sync indicator out of the avatar overlay into a dedicated right-aligned column in each account row by updating src/gui/tray/UserLine.qml to add a syncStatusColumn that reserves space even when empty.
  • Increased the account menu width budget in src/gui/tray/CurrentAccountHeaderButton.qml by adding an extraMenuWidth so rows do not get cramped.
  • Added syncStatusIcon and syncStatusOk properties to User and new roles SyncStatusIconRole/SyncStatusOkRole in UserModel (src/gui/tray/usermodel.h / src/gui/tray/usermodel.cpp).
  • Implemented sync status computation in usermodel.cpp with determineSyncStatus and syncStatusForAccount, mapping folder sync results to theme icons (ok, error, warning, pause, sync, offline) and wired FolderMan/AccountState signals to call updateSyncStatus() and emit model changes.

Testing

  • No automated unit or integration tests were executed for this QML layout and model change.
  • An attempt to capture a visual verification via a headless browser script failed due to no local UI target being available (ERR_EMPTY_RESPONSE).
  • Basic runtime/format checks were used during development but no automated build or CI tests were run on the modified code.

Codex Task

Signed-off-by: Rello <Rello@users.noreply.github.com>
@Rello Rello marked this pull request as draft February 5, 2026 10:45
@Rello Rello changed the title fix: move per-account sync indicator into right-aligned account column feat(tray): sync status indicator in account menu Feb 5, 2026
@Rello Rello moved this to 🏗️ In progress in 💻 Desktop Clients team Feb 5, 2026
@Rello Rello added 3. to review design Design, UI, UX, etc. labels Feb 5, 2026
@Rello Rello added this to the 33.0.0 milestone Feb 5, 2026
@Rello Rello self-assigned this Feb 6, 2026
Rello added 13 commits February 9, 2026 14:55
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
@Rello Rello marked this pull request as ready for review February 16, 2026 13:24
@github-actions
Copy link
Copy Markdown

Artifact containing the AppImage: nextcloud-appimage-pr-9427.zip

Digest: sha256:ae1f31479719e886217e2ba29131ccfbc8a4edc6ae5f85229267614b6846b43e

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@Rello
Copy link
Copy Markdown
Collaborator Author

Rello commented Feb 16, 2026

Bildschirmfoto 2026-02-11 um 16 17 31

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
Image 1 Security Hotspot
Image 0.0% Coverage on New Code (required ≥ 80%)
Image 41 New Code Smells (required ≤ 0)
Image B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

@Rello Rello merged commit 1e00772 into master Feb 16, 2026
23 of 26 checks passed
@Rello Rello deleted the codex/add-sync-status-overlay-to-user-avatars branch February 16, 2026 14:10
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants